Workflow #183
Merged
Workflow #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added building zlib as optional quieted warnings on cmake build
Consolidated github workflow Added macOS to the workflow Updated readme.md to standardized cmake instructions
strattond
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes updates from the cmake pull request
Consolidates github workflows to a single one, that will build on all three OS (to include macOS)
(Status can be gotten on the individual builds through the GitHub interface)
Modified readme.md , to consolidate cmake build commands for all OS's. Also eliminated need to create build directory as the cmake instruction (-B) will auto create it.